feat(whiteboard): Add optional whiteboard backend Deployment#718
Open
Shevonar wants to merge 2 commits intonextcloud:mainfrom
Open
feat(whiteboard): Add optional whiteboard backend Deployment#718Shevonar wants to merge 2 commits intonextcloud:mainfrom
Shevonar wants to merge 2 commits intonextcloud:mainfrom
Conversation
Closes nextcloud#701 Signed-off-by: Matthias Horne <infomh@anmaruco.de>
Signed-off-by: Matthias Horne <infomh@anmaruco.de>
|
When we can merge this MR? |
Collaborator
|
I am really sorry. I personal do not like ATM to merge any features which i do not use. For me it is already too much to maintain this repository (without merge my own PRs). I ask alreay for help here #739 , but the few new maintainers do not review itself. Maybe it change sometime (more active maintainers or i got more time to review/test/use it). Current i could only promise to merge changes on the current Helm-Chart for easiert add this features by changing values (and add the deployment beside this helm-chart). |
|
that's okay. I can still copy the template and apply them manually. |
Collaborator
|
we have a well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds an option to deploy the backend server for the Nextcloud Whiteboard app. It also includes another ingress to expose the backend server to the user. A startup hook automatically configures the required URL and JWT_SECRET_KEY for the Nextcloud Whiteboard app to connect to the backend server.
Benefits
This change provides an easy way to deploy the Whiteboard backend.
Possible drawbacks
Unless
whiteboard.enabledis set totruenothing will change.Applicable issues
Additional information
I tested this change on my personal Nextcloud instance where I run with Ingresses and TLS enabled. I'm not sure if there need to be additional adjustments for other setups.
Checklist
Chart.yamlaccording to semver.